Re: [Qemu-devel] [PATCH] cocoa.m issues fixed

[G 3]

On Jun 21, 2009, at 6:10 AM, Andreas Färber wrote:

> Am 21.06.2009 um 03:19 schrieb G 3:
>
> > +int cocoa_keycode_to_qemu(int keycode);
> > +
>
> This seems unrelated. I believe you're trying to suppress a warning 
> I've been seeing on 10.5 as well - if so, please provide that as a 
> separate patch with appropriate description.

This function prototype would eliminate this warning:
cocoa.m:233: warning: no previous prototype for `cocoa_keycode_to_qemu'

Why a separate patch. Why not kill two birds with one stone?



> > +        char bin[5] = "qemu";
>
> What warning/error does this solve?

This is the warning that this change resolves:
cocoa.m:786: warning: initialization discards qualifiers from pointer 
target type