[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block-raw: Make cache=off default again
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] block-raw: Make cache=off default again |
Date: |
Mon, 22 Jun 2009 15:20:54 +0200 |
User-agent: |
Thunderbird 2.0.0.21 (X11/20090320) |
Anthony Liguori schrieb:
> Kevin Wolf wrote:
>> Since the patch that suggested it woudl revert qcow2 to writeback caching, in
>> fact none of the drivers has had cache=off as default any more. This patch
>> restores the desired behaviour.
>>
>
> When has cache=off ever been the default?
>
> Moreover, why would we want to make it the default? A patch with this
> drastic of a change really need a more significant justification in the
> change log.
Hm, you're right. Why is everyone talking about cache=off being default
except for qcow2? This was confusing me. Not handling the default
explicitly but checking the negation of it in 'else if (!(bdrv_flags &
BDRV_O_CACHE_WB))' has done the rest.
Sorry, I take this patch back.
Kevin
- Re: [Qemu-devel] [PATCH] block-raw: Make cache=off default again, (continued)
- Re: [Qemu-devel] [PATCH] block-raw: Make cache=off default again, Avi Kivity, 2009/06/22
- Re: [Qemu-devel] [PATCH] block-raw: Make cache=off default again, Kevin Wolf, 2009/06/22
- Re: [Qemu-devel] [PATCH] block-raw: Make cache=off default again, Jamie Lokier, 2009/06/23
- Re: [Qemu-devel] [PATCH] block-raw: Make cache=off default again, Kevin Wolf, 2009/06/23
- Re: [Qemu-devel] [PATCH] block-raw: Make cache=off default again, Jamie Lokier, 2009/06/24
- Re: [Qemu-devel] [PATCH] block-raw: Make cache=off default again, Kevin Wolf, 2009/06/25
- Re: [Qemu-devel] [PATCH] block-raw: Make cache=off default again, Christoph Hellwig, 2009/06/22
- Re: [Qemu-devel] [PATCH] block-raw: Make cache=off default again, Kevin Wolf, 2009/06/22
- Re: [Qemu-devel] [PATCH] block-raw: Make cache=off default again, Avi Kivity, 2009/06/22
Re: [Qemu-devel] [PATCH] block-raw: Make cache=off default again, Anthony Liguori, 2009/06/22