[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [POLL] slirp statistics - enable or drop them?
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [POLL] slirp statistics - enable or drop them? |
Date: |
Mon, 22 Jun 2009 15:58:47 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Anthony Liguori wrote:
> Jan Kiszka wrote:
>> Hi,
>>
>> I just broke (locally) the slirp statistics. You know: "info slirp".
>> Maybe you don't because they are off by default, and there is even no
>> hidden configure switch to enable them ("#define LOG_ENABLED" or
>> "-DLOG_ENABLED" is required). Before fixing them again, I wonder if
>> there are actually use cases out there.
>>
>> Basically I have three options now:
>>
>> - drop them completely (would make my nice, 1600-lines dropping slirp
>> cleanup patch even nicer...)
>>
>
> Yes, I'd say drop them.
>
> What's this "dropping slirp cleanup patch"? Just something you use
> locally or do you plan on pushing it to the list?
Hacking on slirp, I quickly got sick of of all those "#if 0", "/*
no-longer-used */" or "#ifndef CONFIG_QEMU" and finally dropped them.
It's not a complete cleanup yet (e.g. one would have to go through
slirp_config.h as well, and we need a re-indention run), but it's a start.
Will definitely post it, at latest when my queue is about to overflow
(currently 30 patches, still increasing).
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
Re: [Qemu-devel] [POLL] slirp statistics - enable or drop them?, Anthony Liguori, 2009/06/22
- Re: [Qemu-devel] [POLL] slirp statistics - enable or drop them?,
Jan Kiszka <=