|
From: | Gerd Hoffmann |
Subject: | Re: [Qemu-devel] Re: [PATCH 0/10] qdev patches. |
Date: | Mon, 22 Jun 2009 16:02:03 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 |
Hi,
This is exactly the sort of fake conversion that I don't like, because you still require use of the old hardcoded initialization functions.I'd prefer to call them "incomplete" instead of "fake". I know that more work needs to be done to get the drivers into shape for a dt-driven machine creation.
To followup with some more backgroud on that on that: These are cases where additional arguments are passed to the *_init() function.
Partly the reason is irq windup (i.e. passing around qemu_irqs), which must be adapted. Didn't investigate that one yet. Probably non-trivial to the way interrupts work (pic, lapic, ioapic, ...) in PCs.
Partly the arguments carry extra configutation info. In that case the info should probably come as attributes from the the device tree. Didn't look (yet) into using attributes, one of the reasons being that the API for them is still quite unclear.
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |