Re: [Qemu-devel] [PATCH] Fix net.c coding style (with regard to tabs)

[Jean-Christophe Dubois]

Le lundi 22 juin 2009 10:29:10 Kevin Wolf, vous avez écrit :
> Jean-Christophe DUBOIS schrieb:
> > This patch will replace existing tab in net.c with spaces
> > in accordance with qemu CODING_STYLE.
> >
> > Note: This first patch is more of a test to see if it
> > will be accepted and if it is worth spending my time on
> > fixing the same issue in other files.
> >
> > Signed-off-by: Jean-Christophe DUBOIS <address@hidden>
>
> I wouldn't do this. We should just pay attention to do it right in code
> touched by new patches.

Some people are speaking about not killing 2 birds with one stone (and I don't 
speak about the kitten ;-) ) and in general I would think you should fix one 
problem per patch. I am not sure it is a good idea to ask somebody fixing one 
line in a file to also fix all the coding style issues of this same file. The 
real patch would be lost into a slew of unrelated changes. Is it not better to 
have a coding style only patch that bring the file to par?

Now you can certainly manage this the way you prefer.

JC

> Kevin