[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] block: Clean up after deleting BHs
From: |
Avi Kivity |
Subject: |
[Qemu-devel] [PATCH] block: Clean up after deleting BHs |
Date: |
Tue, 23 Jun 2009 16:20:36 +0300 |
Commit 6a7ad299 ("Call qemu_bh_delete at bdrv_aio_bh_cb") deletes emulated
aio bottom halves to prevent endless accumulation. However, it leaves a
stale ->bh pointer, which is then waited on when the aio is reused.
Zeroing the pointer fixes the issue, allowing vmdk format images to be used.
Signed-off-by: Avi Kivity <address@hidden>
---
block.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/block.c b/block.c
index aca5a6d..cefbe77 100644
--- a/block.c
+++ b/block.c
@@ -1374,6 +1374,7 @@ static void bdrv_aio_cancel_em(BlockDriverAIOCB *blockacb)
{
BlockDriverAIOCBSync *acb = (BlockDriverAIOCBSync *)blockacb;
qemu_bh_delete(acb->bh);
+ acb->bh = NULL;
qemu_aio_release(acb);
}
@@ -1391,6 +1392,7 @@ static void bdrv_aio_bh_cb(void *opaque)
qemu_vfree(acb->bounce);
acb->common.cb(acb->common.opaque, acb->ret);
qemu_bh_delete(acb->bh);
+ acb->bh = NULL;
qemu_aio_release(acb);
}
--
1.6.2.2
- [Qemu-devel] [PATCH] block: Clean up after deleting BHs,
Avi Kivity <=
- Re: [Qemu-devel] [PATCH] block: Clean up after deleting BHs, Filip Navara, 2009/06/23
- Re: [Qemu-devel] [PATCH] block: Clean up after deleting BHs, Christoph Hellwig, 2009/06/23
- Re: [Qemu-devel] [PATCH] block: Clean up after deleting BHs, Avi Kivity, 2009/06/23
- Re: [Qemu-devel] [PATCH] block: Clean up after deleting BHs, Christoph Hellwig, 2009/06/23
- Re: [Qemu-devel] [PATCH] block: Clean up after deleting BHs, Avi Kivity, 2009/06/23
- Re: [Qemu-devel] [PATCH] block: Clean up after deleting BHs, Christoph Hellwig, 2009/06/23
- Re: [Qemu-devel] [PATCH] block: Clean up after deleting BHs, Avi Kivity, 2009/06/23
- Re: [Qemu-devel] [PATCH] block: Clean up after deleting BHs, Filip Navara, 2009/06/23