Re: [Qemu-devel] Re: [PATCH 01/11] QMP: Introduce specification file

[Eduardo Habkost]

On Tue, Jun 23, 2009 at 04:30:32PM +0300, Avi Kivity wrote:
> On 06/23/2009 04:12 PM, Anthony Liguori wrote:
>> Hi Luiz,
>>
>> The specification looks pretty good.
>>
>>
>>>> +
>>>> +3.3.1 Server Greeting
>>>> +---------------------
>>>> +
>>>> +Sent when a new connection is opened.
>>>> +
>>>> +Format: + OK QEMU<version>  QMP<version>
>>>> +Example: + OK QEMU 0.10.50 QMP 0.1
>>>
>>> Clients should never make decisions based on the qemu or qmp  
>>> version.  Rather, we should provide a facility to query the  
>>> availability of features.
>>
>> I agree, but I'd suggest leaving the QMP version in there for  
>> insurance purposes in case we really screw up and need to bump the  
>> version.  In fact, having the client also negotiate the QMP version  
>> isn't a bad idea.
>
> Agreed.
>
>> How would asynchronous commands work? 
>
> IMO, there aren't any.  All commands are synchronous (but may cause  
> events to be generated later).

And if there is any, we can simply convert them to synchronous commands
that cause events to be generated.

I think we could make this clear on the specification, specifying that
all commands are synchronous.

-- 
Eduardo