[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 05/15] Make --disable-usb to really remove usb s
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH 05/15] Make --disable-usb to really remove usb support |
Date: |
Tue, 23 Jun 2009 19:29:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
address@hidden wrote:
> From: Juan Quintela <address@hidden>
>
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> Makefile | 7 ++++++-
> Makefile.target | 7 ++++++-
> configure | 34 ++++++++++++++++++++++------------
> hw/nseries.c | 2 ++
> hw/pc.c | 2 ++
> hw/ppc_newworld.c | 2 ++
> hw/ppc_oldworld.c | 3 ++-
> hw/ppc_prep.c | 2 ++
> hw/pxa2xx.c | 4 ++++
> hw/realview.c | 2 ++
> hw/usb.h | 3 +++
> hw/versatilepb.c | 2 ++
> monitor.c | 2 ++
> qemu-monitor.hx | 4 ++++
> qemu-options.hx | 2 ++
> sysemu.h | 4 ++++
> vl.c | 14 +++++++++++---
> 17 files changed, 78 insertions(+), 18 deletions(-)
>
...
> diff --git a/hw/nseries.c b/hw/nseries.c
> index b412aa0..55648e1 100644
> --- a/hw/nseries.c
> +++ b/hw/nseries.c
> @@ -1314,8 +1314,10 @@ static void n8x0_init(ram_addr_t ram_size, const char
> *boot_device,
> n8x0_dss_setup(s);
> n8x0_cbus_setup(s);
> n8x0_uart_setup(s);
> +#ifdef CONFIG_USB
> if (usb_enabled)
> n8x0_usb_setup(s);
> +#endif
I think there are some good patterns available to avoid this #ifdef all
over the place. Check how kvm_enabled works, e.g.
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
- [Qemu-devel] [RFC PATCH 00/15] Be able to compile out not needed options, quintela, 2009/06/23
- [Qemu-devel] [PATCH 01/15] Only compile-in selected audio drivers, quintela, 2009/06/23
- [Qemu-devel] [PATCH 03/15] rename usb variable to usb host, quintela, 2009/06/23
- [Qemu-devel] [PATCH 04/15] protect with CONFIG_BRLAPI, quintela, 2009/06/23
- [Qemu-devel] [PATCH 02/15] Make --disable-bluez to really remove bluetooth support, quintela, 2009/06/23
- [Qemu-devel] [PATCH 05/15] Make --disable-usb to really remove usb support, quintela, 2009/06/23
- [Qemu-devel] Re: [PATCH 05/15] Make --disable-usb to really remove usb support,
Jan Kiszka <=
- [Qemu-devel] [PATCH 07/15] add option to remove scsi support, quintela, 2009/06/23
- [Qemu-devel] [PATCH 06/15] Add --disable-smb to remove smb directories support, quintela, 2009/06/23
- [Qemu-devel] [PATCH 08/15] add option to disable wmware devices, quintela, 2009/06/23
- [Qemu-devel] [PATCH 09/15] ssi bus is only used on the arm platform, quintela, 2009/06/23
- [Qemu-devel] [PATCH 11/15] sd flash is only used in arm devices, quintela, 2009/06/23