[Qemu-devel] Re: [patch 1/2] Introduce -smp , maxcpus= flag to specify maximum number of CPUS.

[Avi Kivity]

On 06/24/2009 12:02 PM, Jes Sorensen wrote:
> On 06/24/2009 11:02 AM, Avi Kivity wrote:
> > On 06/24/2009 11:35 AM, Jes Sorensen wrote:
> > > Follow on patch will use it to determine the size of the MADT and
> > > other BIOS tables.
> > >
> > > +int max_cpus = 16;
> >
> > Again I should have noticed this before, but this and the other
> > constants should come from the QEMUMachine we're targeting, since each
> > target has different limits.
>
> Actually this is on purpose. The PC machine has a max limit of 255, if
> we use that as the max per default, you are going to get a BIOS
> declaring 255 possible CPUs and certain broken operating systems are not
> going to boot.
>
> So I will argue the code is correct as is.

What about the various ARMs, powerpcs, and sparcs that we support?

--
error compiling committee.c: too many arguments to function