[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] drive_add vs. pci_add
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] drive_add vs. pci_add |
|
Date: |
Thu, 25 Jun 2009 18:07:23 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Avi Kivity wrote:
> On 06/25/2009 09:46 AM, Jan Kiszka wrote:
>> Hi,
>>
>> sorry, it's still early, but isn't the monitor command 'drive_add'
>> completely redundant to 'pci_add ... storage'? If yes, and drive_add is
>> only there for legacy users, I would mask its help from the monitor
>> interface to avoid confusion.
>>
>
> What we really want is pci_add storage to add a storage controller, and
> drive_add to attach a drive to that controller. I don't think that's
> what happens now.
>
The latter should already happen, but we probably need to drop that
"first drive included" from the former. Also, there is no drive_remove.
I'm going to did into the whole hotplug user interface later, it has
some room for improvements.
Jan
signature.asc
Description: OpenPGP digital signature