[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Substitute O_SYNC with O_FSYNC in block/raw-pos
|
From: |
Christoph Hellwig |
|
Subject: |
Re: [Qemu-devel] [PATCH] Substitute O_SYNC with O_FSYNC in block/raw-posix.c |
|
Date: |
Fri, 26 Jun 2009 19:55:38 +0200 |
|
User-agent: |
Mutt/1.3.28i |
On Thu, Jun 25, 2009 at 08:59:35PM -0400, G 3 wrote:
> This patch will allow the file block/raw-posix.c to compile on gcc 3.3
> on Mac OS 10.3. Since the O_SYNC symbol is missing on this version of
> the Mac OS, O_FSYNC will be used in its place.
Same comment about the zero as last time still applies. Also the
look of this is really ugly as you just deinfe O_SYNC only for it
to substitute for O_DSYNC a littler later, with two comments that
together are rather confusing about macos..