[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] Warn if a qcow (not qcow2) file is opened
From: |
Avi Kivity |
Subject: |
[Qemu-devel] [PATCH] Warn if a qcow (not qcow2) file is opened |
Date: |
Mon, 29 Jun 2009 17:04:49 +0300 |
The qcow block driver format is no longer maintained and likely contains
serious data corruptors. Urge users to stay away for it, and advertise
the new and improved replacement.
Signed-off-by: Avi Kivity <address@hidden>
---
block/qcow.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/block/qcow.c b/block/qcow.c
index 55a68a6..2aef6a6 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -101,6 +101,11 @@ static int qcow_open(BlockDriverState *bs, const char
*filename, int flags)
return ret;
if (bdrv_pread(s->hd, 0, &header, sizeof(header)) != sizeof(header))
goto fail;
+
+ fprintf(stderr,
+ "WARNING: the qcow file format is no longer supported.\n"
+ " Please convert your images to qcow2.\n");
+
be32_to_cpus(&header.magic);
be32_to_cpus(&header.version);
be64_to_cpus(&header.backing_file_offset);
--
1.6.0.6
- [Qemu-devel] [PATCH] Warn if a qcow (not qcow2) file is opened,
Avi Kivity <=
- Re: [Qemu-devel] [PATCH] Warn if a qcow (not qcow2) file is opened, Kevin Wolf, 2009/06/30
- Re: [Qemu-devel] [PATCH] Warn if a qcow (not qcow2) file is opened, Anthony Liguori, 2009/06/30
- Re: [Qemu-devel] [PATCH] Warn if a qcow (not qcow2) file is opened, Kevin Wolf, 2009/06/30
- Re: [Qemu-devel] [PATCH] Warn if a qcow (not qcow2) file is opened, Avi Kivity, 2009/06/30
- Re: [Qemu-devel] [PATCH] Warn if a qcow (not qcow2) file is opened, Paul Brook, 2009/06/30
- Re: [Qemu-devel] [PATCH] Warn if a qcow (not qcow2) file is opened, Daniel P. Berrange, 2009/06/30
- Re: [Qemu-devel] [PATCH] Warn if a qcow (not qcow2) file is opened, Anthony Liguori, 2009/06/30
Re: [Qemu-devel] [PATCH] Warn if a qcow (not qcow2) file is opened, Amit Shah, 2009/06/30