Re: [Qemu-devel] EXT3-fs error on Git HEAD

[Kevin Wolf]

Frank Arnold schrieb:
> Am Montag, den 29.06.2009, 13:42 +1000 schrieb Erik de Castro Lopo:
>> Erik de Castro Lopo wrote:
>>
>>> I have a number of Qemu VMs. Over the weekend I updated to the latest
>>> Git head and now two of my VMs (one i386 and one x86-64) are having
>>> disk errors. Strange thing is, my arm VM is working flawlessly.
>> These VM disk images are all qcow. The i386 and x86-64 ones I converted
>> to qcow2 and they now work fine. The arm one is still qcow and is still
>> working fine.
> 
> We're seeing the same on qemu-kvm.git. I tracked it down to following
> commits:
> 
> commit c16b5a2ca0b186de618654a576bdad9cdd2d1ab2
> Author: Christoph Hellwig <address@hidden>
> Date:   Mon May 25 12:37:32 2009 +0200
> 
>     fully split aio_pool from BlockDriver
> 
> commit ad53089b0d0b4bc0731d978e5713365e1a91ba74
> Author: Christoph Hellwig <address@hidden>
> Date:   Mon May 25 15:45:37 2009 +0200
> 
>     qcow: add qcow_aio_setup helper

This one has an obvious bug. Does the following change help?

diff --git a/block/qcow.c b/block/qcow.c
index 55a68a6..7fc85ae 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -723,7 +723,7 @@ static BlockDriverAIOCB
*qcow_aio_writev(BlockDriverState *bs,

     s->cluster_cache_offset = -1; /* disable compressed cache */

-    acb = qcow_aio_setup(bs, sector_num, qiov, nb_sectors, cb, opaque, 0);
+    acb = qcow_aio_setup(bs, sector_num, qiov, nb_sectors, cb, opaque, 1);
     if (!acb)
         return NULL;

Kevin