[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] move -Wno-error=uninitialized to configure
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [PATCH] move -Wno-error=uninitialized to configure |
|
Date: |
Tue, 30 Jun 2009 15:12:40 +0300 |
|
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Tue, Jun 30, 2009 at 01:07:34PM +0100, Paul Brook wrote:
> On Tuesday 30 June 2009, Michael S. Tsirkin wrote:
> > Move -Wno-error=uninitialized out of rules.mak and into configure. Only
> > use it if supported by compiler.
>
> Why? Shouldn't we be fixing the uninitialized variables?
>
> Paul
gcc's algorithm for detecting uninitialized variables is
famously unreliable. Just scattering '= 0' around the code
masks the warning but hides the fact that application logic
might still be broken.
--
MST
Re: [Qemu-devel] [PATCH] move -Wno-error=uninitialized to configure, Avi Kivity, 2009/06/30