|
From: | Anthony Liguori |
Subject: | Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT aba800a] qemu/virtio: MSI-X support in virtio PCI |
Date: | Tue, 30 Jun 2009 08:10:55 -0500 |
User-agent: | Thunderbird 2.0.0.21 (X11/20090320) |
Michael S. Tsirkin wrote:
On Tue, Jun 30, 2009 at 08:34:50AM +0200, Laurent Desnogues wrote:On Tue, Jun 30, 2009 at 2:57 AM, Anthony Liguori<address@hidden> wrote:From: Michael S. Tsirkin <address@hidden> This enables actual support for MSI-X in virtio PCI. First user will be virtio-net. Signed-off-by: Michael S. Tsirkin <address@hidden> Signed-off-by: Anthony Liguori <address@hidden>[...]diff --git a/rules.mak b/rules.mak index 8d6d96e..defee1d 100644 --- a/rules.mak +++ b/rules.mak @@ -1,6 +1,6 @@ %.o: %.c - $(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $<," CC $(TARGET_DIR)$@") + $(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werror -Wno-error=uninitialized -c -o $@ $<," CC $(TARGET_DIR)$@")-Wno-error=uninitialized is a rather recent addition to gcc and will probably break compilation on many systems.
Adding something like this in the middle of a patch, in the middle of a big series, is also a really bad thing to do. If you want to change build arguments, it should be a separate patch.
I removed this. There are no warnings with my GCC. You can submit follow up patches trying to make a case for different ways to handle this but please separate this sort of stuff out in the future.
Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |