[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH] qdev: add -pcidevice command line option.
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [RFC PATCH] qdev: add -pcidevice command line option. |
Date: |
Tue, 30 Jun 2009 15:37:09 +0200 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux) |
Paul Brook <address@hidden> writes:
> On Monday 29 June 2009, Gerd Hoffmann wrote:
>> Here is a patch adding a generic -pcidevice command line switch.
>
> This sort of feature is one of the reasons I object to "partial" qdev
> conversions. A partially converted device will break in unfriendly ways when
> you try to instantiate it via this option or a machine config file.
>
> Paul
I don't think these are sensible reasons to block progress on qdev
conversions.
The machine config file does not exist, and won't be useful until the
devices are converted to qdev.
-pcidevice can be useful now, for devices converted to qdev, but it
doesn't fully work for certain incomplete conversions. While that's
inacceptable for a release, is it really so horrible as a transient step
now? Besides, we can easily flag incompletely converted devices, and
make -pcidevice not touch them.