Re: [Qemu-devel] [PATCH 01/11] QMP: Introduce specification file

[Avi Kivity]

On 06/30/2009 04:30 PM, Anthony Liguori wrote:
> Avi Kivity wrote:
> > Writing parsers and emitters should be a required part of writing a 
> > qemu control program?
>
> That's what libraries are for.  The thing that you still haven't 
> addressed with JSON, is that there isn't a huge community of JSON 
> parsers out there.  The only json library available in Fedora 10 for C 
> appears to be json-glib which carries a GObject dependency.  
> Practically speaking, if we did use JSON, we would have to provide our 
> own parser library.

There are around 100 parsers listed on json.org.  We can make the 
machine protocol optional and dependant on the existence of a json 
parser of our choice, and Fedora will have to package that dependency if 
they want to build the machine protocol.

Clients are free to use a library or write their own parser.  If we 
provided a parser library it would be useless for all but one client.  
If we support a common format, clients can reuse an existing library.

> > > I will commit a patch series that meets these goals.
> >
> > We have six months so you'll commit some unreviewed patches now?
>
> Where does unreviewed come from? 

Sorry, I understood "I will commit" as "I will personally write and 
commit", not as "I will commit Luiz's suitably modified patchset".

> Why does the emission format have to be perfect in order to start 
> refactoring the monitor interfaces?  There is a large bit of this work 
> effort that has nothing to do with output format.  I don't want to 
> block that work effort.

It does not, and modifying the internals to support a serializable 
object model can be done in parallel to the json flamewar.

--
error compiling committee.c: too many arguments to function