[Qemu-devel] [PATCH] ATAPI pass through

[Bique Alexandre]

Hi,

This patch implements ATAPI pass through on Linux by using bsg device.

What works:
 - read CD
 - burn CD with TAO
 - blank CD
 - play audio CD
 - play DVD movie

What doesn't work:
 - burn CD with SAO

DVD blanking and burning needs some testing.

Things which can be done better:
 - I exported the data structure BDRVRawState from raw-posix.c in raw-posix.h, 
because I use the file descriptor of the bsg device to poll, write and read. 
Maybe there is a better solution, but I didn't find what I was looking for in 
block.h.
 - file splitting: everything is in ide.c, even my atapi pass through code in 
the beginning. I didn't want to put everything in this file so I moved my code 
in atapi-pt.c but I did #include "atapi-pt.c" in ide.c so it's still in the 
spirit of what has been done before: all in ide.c. I'd like to split correctly 
this code but I will have to make some static functions public, and if I move 
atapi-pt out from ide.c why not atapi out from ide.c and maybe some other 
stuff ? That's why I did nothing yet. What would you prefer ?

Please, can you comment on this patch ? Thank you very much.

Regards,
-- 
Alexandre Bique

atapi-pass-through
Description: Text Data