Re: [Qemu-devel] [PATCH] qcow1: Fix qcow_aio_writev

[Christoph Hellwig]

On Tue, Jun 30, 2009 at 06:55:13PM +0200, Kevin Wolf wrote:
> Christoph Hellwig schrieb:
> > On Tue, Jun 30, 2009 at 03:37:17PM +0200, Kevin Wolf wrote:
> >> Pass is_write = 1 to qcow_aio_setup when writing.
> > 
> > Looks correct, sorry for introducing this.
> > 
> > Maybe we should add symbolic names for READ/WRITE in another patch to
> > make this more easily spottable?
> 
> I'd expect we'll not see such things in the same place again, but
> symbolic constants are always better. Are you going to prepare a patch?

I'll put it on my todo list, after some higher priority items :)