[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ATAPI pass through
From: |
Christoph Hellwig |
Subject: |
Re: [Qemu-devel] [PATCH] ATAPI pass through |
Date: |
Tue, 30 Jun 2009 19:01:00 +0200 |
User-agent: |
Mutt/1.3.28i |
On Tue, Jun 30, 2009 at 04:34:53PM +0100, Bique Alexandre wrote:
> - I exported the data structure BDRVRawState from raw-posix.c in
> raw-posix.h,
> because I use the file descriptor of the bsg device to poll, write and read.
> Maybe there is a better solution, but I didn't find what I was looking for in
> block.h.
The way we do scsi passthrough (and ATAPI really just is SCSI
passthrough over ATA with a slightly special command set) is to call
into the ioctl/aio_ioctl methods of the block driver and let that do
the actual I/O. I think your patch would be simpler and cleaner by
following that model