qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/8] qdev/core: bus list


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 4/8] qdev/core: bus list
Date: Tue, 30 Jun 2009 15:36:09 -0500
User-agent: Thunderbird 2.0.0.21 (X11/20090320)

Gerd Hoffmann wrote:
On 06/30/09 21:49, Anthony Liguori wrote:
I think it's a perfectly valid suggestion that we should identify buses
based on the their location in the tree to users verses a number
generated based on some hashing algorithm.
>
A tree location has meaning to a user. A random integer doesn't.

Well. Depends on the bus I think. About PCI devices the usual user probably thinks in terms of "$bus:$slot.$function", which includes a bus number.

But if you think of SCSI as a bus, then it makes more sense to enumerate each SCSI bus by the tree location (which would end up being the PCI location) than a made up number.

Speaking of PCI: the PCI bus number (aka PCIBus->bus_num) has nothing to do with the more or less random bus number introduced by the (now dropped) patch (aka PCIBus->qdev.busnr).

Yup.

Which indicates that it is probably less confusing to have the bus implementation handle the enumeration of busses. If it makes sense for the bus in question of course. sysbus probably doesn't care ;)

That's probably a good point.

Regards,

Anthony Liguori





reply via email to

[Prev in Thread] Current Thread [Next in Thread]