Re: [Qemu-devel] [PATCH] ATAPI pass through

[Alexander Graf]

On 30.06.2009, at 18:26, Kevin Wolf wrote:

> Bique Alexandre schrieb:
>
> > - file splitting: everything is in ide.c, even my atapi pass  
> > through code in
> > the beginning. I didn't want to put everything in this file so I  
> > moved my code
> > in atapi-pt.c but I did #include "atapi-pt.c" in ide.c so it's  
> > still in the
> > spirit of what has been done before: all in ide.c. I'd like to  
> > split correctly
> > this code but I will have to make some static functions public, and  
> > if I move
> > atapi-pt out from ide.c why not atapi out from ide.c and maybe some  
> > other
> > stuff ? That's why I did nothing yet. What would you prefer ?
>
> I guess proper splitting wouldn't hurt anyway. ide.c looks way too  
> large.

I don't really know what became of the SCSI layer since I haven't  
looked at it for quite some time now.
But last time I checked, we had a cdrom emulation in scsi-disk.c _and_  
in ide.c.

I personally see no reason for that. Why can't we just have an atapi  
emulation layer in ide.c and use whatever scsi backends we have? That  
way, we'd only need to implement cd-rom and scsi passthrough once and  
have it available either via SCSI or via ATAPI.

Theoretically it should even be possible to do scsi-disk or scsi-tape  
over ATAPI ;-).

I'd really love to see all this cleaned up a bit, but having atapi  
passthrough is probably better than nothing already.

Alex