Re: [Qemu-devel] [PATCH 0/2] Tunnel character device data over VNC (v1)

[Gerd Hoffmann]

On 07/01/09 18:50, Daniel P. Berrange wrote:
> On Wed, Jul 01, 2009 at 06:42:31PM +0200, Gerd Hoffmann wrote:
> >    Hi,
> >
> > > The key requirement here is that it should not
> > > be neccessary to specifically configure each character device to make
> > > it available via VNC.  The admin should be able to configure the char
> > > devices with all current available backends (file, pty, null, tcp, udp,
> > > unix, etc), and regardless of this config be able to snoop on data from
> > > any active VNC client on demand.
> > Hmm.  What is the reason to handle vnc different from
> > unix/tcp/pty/whatever?  I would expect something like '-serial
> > vnc,name=foo' here ...
>
> As I tried to explain, I want to be able to configure the serial devices
> using the existing backends *AND* also have the ability to occassionally
> access the data using a VNC client.

That doesn't answer the question why vnc should be different.

I *do* see the point of being able to have more than one way to access a 
chardev at the same time.  But when building up that infrastructure: 
Why stop half-way through and make it a special hack for vnc?  I think 
it would be *far* more useful to make chardevs in qemu work that way all 
the time.

Each serial-type driver gets a name tag (either user-specified or 
autogenerated).  chardev backends connect by name.  Advantages:

  (1) It is a step forward to a clear split of guest and host state.
  (2) Better test coverage because everybody uses the same code paths.
  (3) You can connect multiple backends to the chardev.  For example
      you can log the console to a file and work interactively via
      pty at the same time.
  (4) We can allow multiple connections for unix/tcp sockets (pretty
      much like the vnc server handles multiple clients today).

Bonus points for making that configurable via monitor, so you can start 
console logging on the fly.  serial console via vnc data stream then 
will be just the sugar on top ;)

> VNC is not intended to be the main
> character device backend here

I'd like to question the concept of a "main chardev backend".

cheers,
  Gerd