[Qemu-devel] Re: [PATCH 09/13] TARGET_ARCH2 is already known at configure time and it is called target_cpu Remove re-construction in Makefile.target

[Juan Quintela]

Blue Swirl <address@hidden> wrote:
> On 7/1/09, address@hidden <address@hidden> wrote:
>> From: Juan Quintela <address@hidden>
>>
>
> TARGET_CPU would be a misleading name. TARGET_ARCH2 means that it's a
> kind of subarchitecture. TARGET_SUBARCH or TARGET_ABI32_NAME should be
> OK too.
>
> For example, there is no CPU type (or even class of CPUs) called
> sparc32plus. There is Sparc (a.k.a. Sparc32, V8) and Sparc64 (a.k.a.
> Ultrasparc, V9, V9plusa etc.). Sparc32plus is a userland mode for
> Sparc64 CPUs where the address space is limited to 32 bits. The same
> probably applies to other 32 bit subarchitectures.

I agree, but I just used the same name than in configure:

case "$target_cpu" in
....
  sparc32plus)
....
esac.

I don't matter the name, but we have just now:

ARCH
cpu
TARGET_ARCH
TARGET_ARCH2
TARGET_BASE_ARCH
target_cpu
TARGET_ABI_DIR

and I am not sure that I have all of them here.  target_cpu and
TARGET_ARCH2 always had the same value, but perhaps changing it to
TARGET_SUBARCH is a good idea.  The we would end:

TARGET_BASE_ARCH: architecture name (mips, sparc, ppc)
TARGET_ARCH: Actual architecture
TARGET_SUBARCH: change about TARGET_ARCH (sparc32plus, little/big endian
                variants) (was TARGET_ARCH2 and target_cpu)
TARGET_ABI: call ABI for this TARGET_SUBARCH
cpu = canonical name for the cpu, not sure how to relate this one with ARCH
ARCH: where are we building, it is always the same than 'cpu' on
      configure, it is only used on the Makefiles, but I would preffer
      to only use one name for the same meaning.

kill also cpu in configure script?

Anyone with a good idea?

Later, Juan.