qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] fix hw/scsi-disk.c compile errors


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH] fix hw/scsi-disk.c compile errors
Date: Thu, 02 Jul 2009 08:46:50 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2

On 07/02/09 01:40, Robert Reif wrote:
This patch fixes 2 compile errors when debugging is enabled.

CC scsi-disk.o
cc1: warnings being treated as errors
/home/reif/qemu/hw/scsi-disk.c: In function ‘scsi_send_command’:
/home/reif/qemu/hw/scsi-disk.c:797: error: format ‘%d’ expects type
‘int’, but argument 2 has type ‘uint64_t’

> -        DPRINTF("Synchronise cache (sector %d, count %d)\n", lba, len);
> + DPRINTF("Synchronise cache (sector %lld, count %d)\n", lba, len);

Doesn't work. Well, it works on 32bit, but will fail on 64bit. Use the macros provided by inttypes.h instead, i.e.

  "... (sector %" PRId64 ", count ...", lba

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]