Re: [Qemu-devel] [PATCH] sdl zooming

[Stefano Stabellini]

On Thu, 25 Jun 2009, Stefano Stabellini wrote:
> Blue Swirl wrote:
> 
> > On 6/24/09, Stefano Stabellini <address@hidden> wrote:
> >> Hi all,
> >>  this patch implements zooming capabilities for the sdl interface.
> >>  A new sdl_zoom_blit function is added that is able to scale and blit a
> >>  portion of a surface into another.
> >>  This way we can enable SDL_RESIZABLE and have a real_screen surface with
> >>  a different size than the guest surface and let sdl_zoom_blit take care
> >>  of the problem.
> >
> > As you are already using the template system, for extra performance,
> > you could remove 'smooth' as parameter and instantiate separate
> > functions for both cases with something like:
> >
> > static int glue(glue(sdl_zoom_rgb, BPP), _ ## SMOOTH)(SDL_Surface
> > *src, SDL_Surface *dst,
> >                                    SDL_Rect *dst_rect)
> >
> > Then s/smooth/SMOOTH/g in the function and adjust callers.
> 
> 
> 
> I am not sure if this change is going to increase the readability of the
> code or the performances by much, but this is the new version of the
> patch nonetheless.
> 

Any update on this?