[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value inst
|
From: |
Stuart Brady |
|
Subject: |
Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value instead of int. |
|
Date: |
Thu, 2 Jul 2009 19:11:13 +0100 |
|
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Thu, Jul 02, 2009 at 07:32:11PM +0900, Isaku Yamahata wrote:
> -void cpu_outb(CPUState *env, int addr, int val)
> +void cpu_outb(CPUState *env, uint32_t addr, uint32_t val)
uint8_t for 'b' and uint16_t for 'w' might be slightly better, in that
it would allow compiler warnings regarding truncations to be generated.
> - LOG_UNUSED_IOPORT("unused inb: port=0x%04x\n", address);
> + LOG_UNUSED_IOPORT(stderr, "unused inb: port=0x%04"PRIx32"\n", address);
These don't look intentional...
--
Stuart Brady
- [Qemu-devel] [PATCH 0/6] ioport related clean ups, Isaku Yamahata, 2009/07/02
- [Qemu-devel] [PATCH 2/6] use constant IOPORTS_MASK instead of 0xffff., Isaku Yamahata, 2009/07/02
- [Qemu-devel] [PATCH 3/6] ioport: consolidate duplicated logic in register_ioport_{read, write}()., Isaku Yamahata, 2009/07/02
- [Qemu-devel] [PATCH 4/6] ioport: remove some #ifdef DEBUG_UNUSED_IOPORT., Isaku Yamahata, 2009/07/02
- [Qemu-devel] [PATCH 1/6] split out ioport related stuffs from vl.c into ioport.c., Isaku Yamahata, 2009/07/02
- [Qemu-devel] [PATCH 5/6] consolidate user cpu_{in, out}[bwl] into ioport-user.c, Isaku Yamahata, 2009/07/02
- [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value instead of int., Isaku Yamahata, 2009/07/02
- Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value instead of int.,
Stuart Brady <=
- Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value instead of int., Anthony Liguori, 2009/07/09
- Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value instead of int., Samuel Thibault, 2009/07/10
- Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value instead of int., Isaku Yamahata, 2009/07/10
- Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value instead of int., Samuel Thibault, 2009/07/10
- Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value instead of int., Tristan Gingold, 2009/07/10
- Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value instead of int., Anthony Liguori, 2009/07/10
- Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value instead of int., Tristan Gingold, 2009/07/10
- Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value instead of int., Anthony Liguori, 2009/07/10
- Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value instead of int., Tristan Gingold, 2009/07/10