qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] Use ctz64 in favor of ffsll


From: Paul Brook
Subject: Re: [Qemu-devel] [PATCH v2] Use ctz64 in favor of ffsll
Date: Fri, 3 Jul 2009 10:35:18 +0100
User-agent: KMail/1.11.4 (Linux/2.6.29-2-amd64; KDE/4.2.4; x86_64; ; )

On Thursday 02 July 2009, Jan Kiszka wrote:
> Not all host platforms support ffsll.

>-            pending_irq = i * 64 + bit - 1;
>+            bit = ctz64(env->interrupt_bitmap[i]);
>+            pending_irq = i * 64 + bit;

Are we sure there is only ever one bit set in interrupt_bitmap?
If not does it mater that we're processing them in reverse order?

Paul




reply via email to

[Prev in Thread] Current Thread [Next in Thread]