|
From: | Avi Kivity |
Subject: | [Qemu-devel] Re: [PATCHv4 4/5] qemu/msi: missing braces |
Date: | Sun, 05 Jul 2009 15:07:06 +0300 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 |
On 07/05/2009 02:56 PM, Michael S. Tsirkin wrote:
With the braces comment I meant that while working on the code, you should update it to match CODING_STYLE: if (!(dev->cap_present& QEMU_PCI_CAP_MSIX)) { return; }Yea ... it's probably better to do this all over the file, not piecewise, though. No?
No, that just causes churn (and merge conflicts for me). Better to only fix if you have a patch that modifies the same place.
-- error compiling committee.c: too many arguments to function
[Prev in Thread] | Current Thread | [Next in Thread] |