qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCHv5 4/5] qemu/msi: missing braces


From: Michael S. Tsirkin
Subject: [Qemu-devel] [PATCHv5 4/5] qemu/msi: missing braces
Date: Sun, 5 Jul 2009 15:58:52 +0300
User-agent: Mutt/1.5.19 (2009-01-05)

MSIX present bit is tested incorrectly, and only happens to work because
the bit we are testing is 0x1.  Add braces to fix this.

Reported-by: Blue Swirl <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
 hw/msix.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/msix.c b/hw/msix.c
index 80038d3..4224d8f 100644
--- a/hw/msix.c
+++ b/hw/msix.c
@@ -298,9 +298,9 @@ void msix_load(PCIDevice *dev, QEMUFile *f)
 {
     unsigned n = dev->msix_entries_nr;
 
-    if (!dev->cap_present & QEMU_PCI_CAP_MSIX)
+    if (!(dev->cap_present & QEMU_PCI_CAP_MSIX)) {
         return;
-
+    }
     msix_free_irq_entries(dev);
     qemu_get_buffer(f, dev->msix_table_page, n * MSIX_ENTRY_SIZE);
     qemu_get_buffer(f, dev->msix_table_page + MSIX_PAGE_PENDING, (n + 7) / 8);
-- 
1.6.2.2





reply via email to

[Prev in Thread] Current Thread [Next in Thread]