[Qemu-devel] Re: [COMMIT 707c0db] support colon in filenames

[Jan Kiszka]

Jan Kiszka wrote:
> Anthony,
> 
> please revert this patch until Ram Pai provides a better version. It
> causes too many problems. At least it
> 
>  - breaks -pflash somefile -snapshot

Some more details on this: it's not just pflash that suffers, -snapshot
was broken for raw images in general. Declaring file access as a
protocol apparently has some unwanted side effects that first have to be
resolved (check also bdrv_open2 /wrt realpath).

>  - breaks mingw32 build due to redefined _open

Sorry, this obviously does not apply to the merged revision 2 but to
rev3 which I had applied locally.

>  - uses PATH_MAX
> 
> rev3 does not fix any of the above.
> 
> At this chance: there is at least one indention issue remaining in
> fill_token() which would be nice to fix while reworking the patch.
> 
> Jan
> 

Jan

signature.asc
Description: OpenPGP digital signature