Re: [Qemu-devel] [PATCH 5/5] ATAPI pass through v2: update the configure

[Christoph Hellwig]

On Mon, Jul 06, 2009 at 02:47:40PM +0100, Bique Alexandre wrote:
> On Sunday 05 July 2009 09:16:37 Christoph Hellwig wrote:
> > On Wed, Jul 01, 2009 at 07:32:04PM +0100, Bique Alexandre wrote:
> > > This patch update the configure by adding --enable-atapi-pt and
> > > --disable-atapi-pt.
> >
> > Do we need an option for this?  I'd say we should make it uncoditional
> > when built on Linux like the SCSI passthrough code.
> 
> Ok, so I just do:
> 
> If Linux then
>       enable
> else
>       disable
> fi

Yes.  Take a look at hw/virtio-blk.c and hw/scsi-generic.c for how we
guard the other pass-through users.