Re: [Qemu-devel] [PATCH] Add new block driver for the VDI format

[Stefan Weil]

Christoph Hellwig schrieb:
> On Sun, Jul 05, 2009 at 04:02:29PM +0200, Stefan Weil wrote:
>   
>> CONFIG_VDI_UNSUPPORTED and CONFIG_VDI_SNAPSHOT document
>> code parts which are still missing or unfinished.
>> For the same reason, they are undefined, so the unfinished
>> code is deactivated.
>>     
>
>   
>> Not having the method would hide the fact that the
>> method might be implemented.
>>
>> vdi_check is unfinished code, and there is even a comment
>> which says that there remains something to do.
>>     
>
> Keeping stubs around as a reminder is very bad coding practice.  You
> already have a todo list reminding about the missing features on the
> top of the file.  Note that the feature set of your vdi driver is the
> same as all the other non-native image format drivers, so it's not
> really anything special anyway.
>   

My opinion about bad coding practices differs from yours.

Why do you think that stubs are even a very bad coding practice?

The potential feature set of the vdi driver is more than that of the
other non-native image format drivers. It is nearer to that of qcow2.

>   
>> By the way - is it possible to check new block drivers like this one
>> using qemu-io (can I use an existing test sequence)?
>>     
>
> I've put support into qemu-iotests to run with the vdi format.  It
> passes all test that currently are available for vdi.
>
>   

Thanks for this feedback. There are still errors in my first driver release
(endianess, block allocation) which will be fixed in the next release.

Regards,

Stefan