Re: [Qemu-devel] [PATCH] sanitize ->bdrv_get_buffer / ->bdrv_put_buffer calling conventions

[Kevin Wolf]

Christoph Hellwig schrieb:
> On Wed, Jul 08, 2009 at 03:46:15PM +0200, Kevin Wolf wrote:
>> Christoph Hellwig schrieb:
>>> The VM state offset is an concept internal to the image format, it
>>> doesn't even have to be a traditional linear offset.  So change the
>>> ->bdrv_get_buffer / ->bdrv_put_buffer calling convention to always pass
>>> a relative offset and add the VM state offset to it internally inside
>>> the qcow2 code.
>> Looks good to me and makes the interface nicer. Maybe we could use the
>> opportunity to change the function names to something like
>> bdrv_vmstate_read/write? get/put_buffer is quite unspecific, it could
>> mean anything.
> 
> Does this one looks good?

I think it does.

Kevin