qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value inst


From: Isaku Yamahata
Subject: Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value instead of int.
Date: Fri, 10 Jul 2009 17:45:08 +0900
User-agent: Mutt/1.5.6i

On Fri, Jul 10, 2009 at 10:21:21AM +0200, Samuel Thibault wrote:
> Anthony Liguori, le Thu 09 Jul 2009 14:07:47 -0500, a écrit :
> > Isaku Yamahata wrote:
> > >use uint32_t for ioport port and value instead of int.
> > >  
> > 
> > Why?
> 
> In theory int could be only signed 16bit, so at least unsigned int could
> be needed for the port. uint16_t should be fine. For value, as said
> uint8/16/32 should probably be better.

Then, the signatures should like the followings?

void cpu_out[bwl](CPUState *env, int64_t addr, int{8, 16, 32}_t val);
uint{8, 16, 32}_t cpu_inw(CPUState *env, int16_t addr);

-- 
yamahata




reply via email to

[Prev in Thread] Current Thread [Next in Thread]