qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value inst


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value instead of int.
Date: Fri, 10 Jul 2009 07:55:44 -0500
User-agent: Thunderbird 2.0.0.21 (X11/20090320)

Isaku Yamahata wrote:
> Then, the signatures should like the followings?
>
> void cpu_out[bwl](CPUState *env, int64_t addr, int{8, 16, 32}_t val);
> uint{8, 16, 32}_t cpu_inw(CPUState *env, int16_t addr);
>   

If anything, it ought to be:

void cpu_out[bwl](CPUState *env, uint16_t addr, int{8, 16, 32}_t val);

But it's int today because the assumption is that most architectures can
more efficiently pass int than other types (because it's the native
type) and that int is adequate to contain all of the necessary types.

But my original question still remains, what's the motivation for this
change?

Regards,

Anthony Liguori





reply via email to

[Prev in Thread] Current Thread [Next in Thread]