Re: [Qemu-devel] [PATCH] build fix: xen on NetBSD/amd64

[Christoph Egger]

On Friday 10 July 2009 14:58:48 Anthony Liguori wrote:
> Christoph Egger wrote:
> > On Thursday 09 July 2009 21:21:06 Anthony Liguori wrote:
> >> Christoph Egger wrote:
> >>> Hi!
> >>>
> >>> Attached patch fixes this build error on NetBSD/amd64:
> >>>
> >>> hw/xen_blkif.h:20: warning: #pragma pack(psuh[, id], <n>) is not
> >>> supported on this target
> >>> hw/xen_blkif.h:36: warning: #pragma pack(pop[, id], <n>) is not
> >>> supported on this target
> >>>
> >>> Signed-off-by: Christoph Egger <address@hidden>
> >>
> >> You'll invoke the fury of malc for introducing an identifier that begins
> >> with '__' :-)
> >
> > In NetBSD, there is this in <sys/cdefs.h> :
>
> NetBSD is allowed to use these names in system headers but according to
> the C standard, normal programs like QEMU aren't.  So we need to use
> something other than __aligned.

What about  __qemu_aligned ?

#ifdef __NetBSD__
#define __qemu_aligned(x)    __aligned(x)
#else
#define __qemu_aligned(x)    __attribute__((__aligned__(x)))
#endif


> Regards,
>
> Anthony Liguori



-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632