Re: [Qemu-devel] Sparc64 breakage by 16eaedf2668e9b347a59d73346fcc4c764c58348

[Blue Swirl]

On 7/10/09, Anthony Liguori <address@hidden> wrote:
> Blue Swirl wrote:
>
> > Hi,
> >
> > APB is not converted to qdev yet, so pci_register_secondary_bus
> > shouldn't use FROM_QBUS. Sparc64 is currently broken.
> >
> > Partially reverting 16eaed... fixes the breakage:
> > diff --git a/hw/pci.c b/hw/pci.c
> > index 71d9227..f592925 100644
> > --- a/hw/pci.c
> > +++ b/hw/pci.c
> > @@ -135,7 +135,7 @@ static PCIBus
> > *pci_register_secondary_bus(PCIDevice *dev,
> pci_map_irq_fn map_irq
> >  {
> >     PCIBus *bus;
> >
> > -    bus = FROM_QBUS(PCIBus, qbus_create(&pci_bus_info, &dev->qdev,
> NULL));
> > +    bus = qemu_mallocz(sizeof(PCIBus));
> >     bus->map_irq = map_irq;
> >     bus->parent_dev = dev;
> >     bus->next = dev->bus->next;
> >
> >
>
>  Gerd, could you take a look?
>
>  Blue, you mentioned that you have an openbios-sparc64 image for testing?
> Would that have uncovered this and if so, do you have a link handy?

We deliver the latest (r505) OpenBIOS image at pc-bios/openbios-sparc64.

To test this bug, the following is enough:
./obj-amd64/sparc64-softmmu/qemu-system-sparc64 -L ./pc-bios/
Segmentation fault

With my patch applied, you get the OpenBIOS Forth prompt.