Re: [Qemu-devel] Sparc64 breakage by 16eaedf2668e9b347a59d73346fcc4c764c58348

[Gerd Hoffmann]

On 07/10/09 21:36, Anthony Liguori wrote:
> Blue Swirl wrote:
> > Hi,
> >
> > APB is not converted to qdev yet, so pci_register_secondary_bus
> > shouldn't use FROM_QBUS. Sparc64 is currently broken.

> > Partially reverting 16eaed... fixes the breakage:
> > --- a/hw/pci.c
> > +++ b/hw/pci.c
> > - bus = FROM_QBUS(PCIBus, qbus_create(&pci_bus_info, &dev->qdev, NULL));
> > + bus = qemu_mallocz(sizeof(PCIBus));

> Gerd, could you take a look?

As sparc64 is the only user of pci_register_secondary_bus() the partial 
reverse is fine IMHO.  Just let us defer this until APB is qdev-ified.

cheers,
  Gerd