qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/13] qdev: add generic qdev_device_add()


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 04/13] qdev: add generic qdev_device_add()
Date: Fri, 10 Jul 2009 22:27:53 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2

On 07/10/09 19:23, Paul Brook wrote:
On Friday 10 July 2009, Gerd Hoffmann wrote:
Will be used for -device command line.

I think this is going in the wrong direction. The device tree provides us with
a standard way of identifying which bus to add a device to. We should be
removing uses of pci_create, not adding new ones.

Why?

Let me guess: Because pci bus numbers are guest-changeable and thus not stable?

How about using user-specified ids to specify busses then?

PCI example:
  instead of  -device $name,addr=$bus:$slot.$fn
  use         -device $name,bus=root,addr=$slot.$fn

SCSI example:
  host adapter:  -device lsi,id=foo
  scsi disk:     -device scsi-disk,bus=foo,addr=$lun

cheers,
  Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]