Re: [Qemu-devel] [PATCH] sparc64: fix helper_st_asi little endian case typo

[Blue Swirl]

On 7/11/09, Igor Kovalenko <address@hidden> wrote:
> On Sun, Jul 12, 2009 at 12:43 AM, Stuart Brady<address@hidden> wrote:
>  > On Sat, Jul 11, 2009 at 10:22:18PM +0400, Igor Kovalenko wrote:
>  >> It is clear that intention is to byte-swap value to be written, not
>  >> the target address.
>  >
>  > @@ -1949,13 +1949,13 @@ void helper_st_asi(target_ulong addr, ta
>  >     case 0x89: // Secondary LE
>  >         switch(size) {
>  >         case 2:
>  > -            addr = bswap16(addr);
>  > +            addr = bswap16(val);
>  >             ^^^^
>  > Shouldn't that be 'val = bswap16(val)' (and likewise for the 32-bit and
>  > 64-bit cases)?  Also needs a 'signed-off-by:'...
>  >
>  > Cheers,
>  > --
>  > Stuart Brady
>  >
>
>
> Thanks, that part I did not runtime-tested.
>  Not sure if those asi stores are of any use for user-mode emulator.
>
>  Please find attached the corrected version.
>
>  Signed-off-by: address@hidden

Thanks, I applied most of your patches.