qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] rev5: support colon in filenames


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH] rev5: support colon in filenames
Date: Thu, 16 Jul 2009 09:43:30 +0200
User-agent: Thunderbird 2.0.0.21 (X11/20090320)

Ram Pai schrieb:
> On Wed, 2009-07-15 at 18:04 +0300, Blue Swirl wrote:
>> On 7/15/09, Ram Pai <address@hidden> wrote:
>>> Problem: It is impossible to feed filenames with the character colon because
>>>  qemu interprets such names as a protocol. For example filename scsi:0, is
>>>  interpreted as a protocol by name "scsi".
>>>  --- a/block/raw-posix.c
>>>  +++ b/block/raw-posix.c
>>>  +static int qemu_open(const char *filename, int flags, ...)
>>>  --- a/block/raw-win32.c
>>>  +++ b/block/raw-win32.c
>>>  +    fd = qemu_open(filename, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY,
>> I bet this won't compile on win32.
> 
> yes. good catch. fix is in the next revision(rev 6). However I do not
> have a setup to compile and test changes in win32-raw.c . I will have to
> rely on somebody to do the testing. 

It's not that complicated to set up a mingw cross build environment.
Have you tried that? At least it would help you to catch compile errors.
(And I usually run it in Wine then to check that it's not completely broken)

Kevin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]