Re: [Qemu-devel] [PATCH] introduce on_vcpu

[Anthony Liguori]

Glauber Costa wrote:
> Yes. Purpose of using curren_env was just to make it look more like qemu-kvm
> But I do understand that we'll have to change it anyway for this code to
> have any actual value, so I'm fine with using cpu_single_env.
>   

Yeah, if qemu-kvm is introduce another global current CPUState variable, 
then the qemu-kvm code has to change :-)

Since qemu-kvm keeps a thread id in CPUState, it would make more sense 
to check whether gettid() == env->thread_id, no?

> > > +        func(data);
> > > +        return;
> > > +    }
> > > +    assert(1);
> > >   
> > >       
> > Wouldn't assert(env == current_env) or abort() make more sense?
> >     
> abort() is fine. I can change it if you prefer.
>   

Please do.

Regards,

Anthony Liguori