Re: [Qemu-devel] [PATCH] sparc64 replace tsptr with helper routine

[Blue Swirl]

On Mon, Jul 20, 2009 at 12:19 AM, Igor
Kovalenko<address@hidden> wrote:
> tl and tsptr of members sparc64 cpu state must be changed
> simultaneously to keep trap state window in sync with current
> trap level. Currently translation of store to tl does not change
> tsptr, which leads to corrupt trap state on corresponding
> trap level.
>
> This patch removes tsptr from sparc64 cpu state and replaces
> all uses with call to helper routine.

I'd rather have the stores to TL fixed instead of introducing a
helper. A new function to set both TL and tsptr may help. Which stores
to TL do not change tsptr?

On CPU reset, TL should be MAXTL for POR and MIN(TL+1, MAXTL) in other
cases but your patch would set it to 0.