[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-io: reject invalid pattern
From: |
Christoph Hellwig |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-io: reject invalid pattern |
Date: |
Mon, 20 Jul 2009 14:33:22 +0200 |
User-agent: |
Mutt/1.3.28i |
On Mon, Jul 20, 2009 at 10:05:34AM +0200, Kevin Wolf wrote:
> > + * Because the pattern is used as an argument to memset it must evaluate
> > + * to an unsigned integer that fits into a single byte.
>
> + * Returns the pattern byte or -1 in case arg does not contain a valid
> pattern
>
> > + pattern = parse_pattern(optarg);
> > + if (pattern < 0)
> > + return 0;
>
> Coding style (braces).
>
> Looks good to me otherwise.
Thanks, I've resent an updated version.