Re: [Qemu-devel] [PATCH, RFC] Sparc64: convert APB to qdev

[Blue Swirl]

On Tue, Jul 21, 2009 at 12:19 AM, Igor
Kovalenko<address@hidden> wrote:
> On Mon, Jul 20, 2009 at 2:26 PM, Blue Swirl<address@hidden> wrote:
>> I have a problem with APB conversion to qdev. For some reason, with
>> the patch applied, PCI config register access changes and OpenBIOS
>> can't find any PCI devices.
>
> You are using pci_host_data_* which expects opaque pointer to PCIHostState,
> so you need to pass appropriate opaque to cpu_register_io_memory.
> With this small amendment I verified there are no changes to qemu.log and
> serial console output.

Great, thanks!

> Not sure if this requires sign-off :)

Good question, perhaps the SoB experts should clarify the policy.

But in this case it makes no sense to commit my broken version and
then your patch. I think I'll just give you credit in the message for
the fixed commit.