Re: [Qemu-devel] Re: [PATCH] update server bits on vnc_update

[Stefano Stabellini]

On Tue, 21 Jul 2009, Stefano Stabellini wrote:
> As a side note: I was reading the new vnc multiclient code to understand
> how the refresh works now, and I have just noticed something that I
> think is wrong:
> 
> we call vga_hw_update in vnc_update_client, that means we call it once
> per vnc client connected! We should call it only once, probably in a
> separate timer, that is enabled only if at least one client is connect.
> 
> 
> I also don't like the fact that we are allocating a server surface per
> client connected, this can become a problem very fast: I think we could
> probably get away with just one server surface for all the clients.
> 
> 

Obviously these are suggestions for improvements and I am willing to
write the patches if you agree with the ideas.