qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/5] Add getfd and closefd monitor commands


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 3/5] Add getfd and closefd monitor commands
Date: Tue, 21 Jul 2009 21:20:48 -0500
User-agent: Thunderbird 2.0.0.21 (X11/20090320)

Mark McLoughlin wrote:
My take on it is that we're all agreed that it's never valid with the
current monitor protocol for a client to queue up multiple fds. It's a
synchronous protocol, you can't send multiple commands at once.

I think there's a subtle point that was lost in the thread. While we'll only need to queue one fd per MonitorState, we'll still need to deal with multiple fds per CharDriverState.

I think the way this would most logically work would be a push interface verses a pull interface so that there wasn't double queuing. That is, whenever the CharDriverState gets an fd, it calls a function registered by the consumer of the CharDriverState.

Regards,

Anthony Liguori





reply via email to

[Prev in Thread] Current Thread [Next in Thread]