|
From: | Gerd Hoffmann |
Subject: | [Qemu-devel] Re: [PATCH 1/2] Introduce CharDriverState qdev property type |
Date: | Wed, 22 Jul 2009 11:48:27 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 |
On 07/21/09 17:47, Anthony Liguori wrote:
Gerd Hoffmann wrote:Not sure what qdev_prop_set_chrdev() should accept then. struct pointer? string?Good question. I think it depends on how we connect things. We could introduce another structure for front-ends and then have a separate connect mechanism. The association of names would be transparent to qdev/devices.
Hmm. When going that route it we might not use attributes at all but just tie stuff directly into Device*, i.e. DeviceState gets a backend link and DeviceInfo gets a connect callback.
We could also hand the chrdev structure directly to the device but then you have to deal with setting/unsetting.
Optional Property->notify() callback should do for devices which actually care (cdrom to signal media change to guest maybe).
cheers, Gerd
[Prev in Thread] | Current Thread | [Next in Thread] |