Re: [Qemu-devel] [PATCH 3/7] Add mp_state to PPC CPU struct

[Hollis Blanchard]

On Wed, 2009-07-22 at 10:34 -0500, Anthony Liguori wrote:
> Alexander Graf wrote:
> > Some generic code tries to access env->mp_state. Let's just make
> > it happy and provide it.
> >
> > Signed-off-by: Alexander Graf <address@hidden>
> >   
> 
> Or we can move that code from kvm-all.c to target-i386/kvm.c where it 
> belongs :-)

Common code uses mp_state, and i386 is the only thing calling that code.
However, the ioctl used by that code is valid for all architectures; it
will just return -EINVAL. Someday we might need it in common code, but
then again it's not even clear to me it will be useful outside of x86.

I'm fine with moving it too, as long as it's also renamed at the same
time. :)

-- 
Hollis Blanchard
IBM Linux Technology Center